8000 Fix new warnings with gcc8 by QuLogic · Pull Request #10775 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix new warnings with gcc8 #10775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2018
Merged

Fix new warnings with gcc8 #10775

merged 2 commits into from
Mar 15, 2018

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Mar 14, 2018

PR Summary

Don't catch polymorphic exceptions by value. We don't use the variable anyway, so the exact type is not a big deal for us.

Also, cleanup the manifest which had some stale entries.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • Code is PEP 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic added 2 commits March 13, 2018 21:41
@QuLogic
Don't catch polymorphic exceptions by value.
26edf61 
This causes warnings with GCC 8, also clangtidy. We don't use the
variable anyway, so the exact type is not a big deal for us.
@QuLogic
Cleanup old entries from manifest.
0c0797b
@QuLogic QuLogic added the Build label Mar 14, 2018
@QuLogic QuLogic added this to the v2.2.1 milestone Mar 14, 2018
@jklymak
Copy link
Member
jklymak commented Mar 14, 2018

Did you need this in for 2.2.1? I think @tacaswell is trying to tag that.

@QuLogic
Copy link
Member Author
QuLogic commented Mar 14, 2018

It's preferable so there are less patches needed downstream (though these are warnings, so I don't really need need it) 2.2.1 or 2.2.2 or whatever doesn't matter too much, but since there are still open items, I'd like to squeeze this one in.

anntzer
anntzer approved these changes Mar 14, 2018
View reviewed 8000 changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like good c++ practice anyways.

@dopplershift dopplershift merged commit 3ef352f into matplotlib:v2.2.x Mar 15, 2018
@QuLogic QuLogic deleted the gcc8-warnings branch March 15, 2018 01:34
@foch1
Copy link
foch1 commented Mar 15, 2018

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@QuLogic @jklymak @foch1 @dopplershift @anntzer
0