FIX: enable extend kwargs with log scale colorbar #10705
Conversation
|
Thanks for the contribution @JelsB. Is it possibe to add a test for this? i.e. I have a PR that will wipe out the old tick decisions, so it'd be nice if this PR includes a test that makes sure I don't do revert your change inadvertently. EDIT: (ooops, sorry for the spurious close/reopen) |
|
@jklymak I'l make a test in the appropriate file. I don't need an image, I just make a data matrix where a logarithmic scale in useful when plotting. But there seems to be a test already |
|
I've added a test case for this fix in |
|
@JelsB unfortunately this is failing on the image tests. Likely your test images are using an incompatible free type version. I think you can add to the image comparison method |
|
I've changed it. I didn't know it matters, some of the already existing test don't have this either. |
|
@JelsB We can't merge tests that don't pass. If you make the test image w/ the incorrect version of FreeType, and they have text in them, they will fail. Your new images are fine, and passing the tests. However, you still have some style (PEP8) issues. Drill down in the travis-ci python 3.6 test to find them. This should be squashed before merging to make sure only one of the images makes it into the Repo. Thanks for your patience with the process! |
|
@jklymak Okay, yes I see the problem. I forgot to check that all of my code has exactly the PEP8 style. I'll fix them. No problem, thanks for guiding me. |
PR Summary
The extend keyword did not work when using a logarithmic colorbar. The extended lower contour level was a large negative number by default, which gives NaN when using a logarithm. A simple fix to change this to a very small positive number when using log scale.
PR Checklist