8000 Simplify venv docs. by anntzer · Pull Request #10696 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Simplify venv docs. #10696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2018
Merged

Simplify venv docs. #10696

merged 1 commit into from
Mar 16, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 6, 2018

Now that venv is in stdlib, we can just recommend it instead of
suggesting a bunch of workarounds for virtualenv on OSX.

In the general venv docs, rework the first paragraph, which was phrased
a bit awkwardly; move vext above virtualenv because the former also
works in venvs (which again should be preferred).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Simplify venv docs.
3586eb3 
Now that venv is in stdlib, we can just recommend it instead of
suggesting a bunch of workarounds for virtualenv on OSX.

In the general venv docs, rework the first paragraph, which was phrased
a bit awkwardly; move vext above virtualenv because the former also
works in venvs (which again should be preferred).
@anntzer anntzer added this to the v3.0 milestone Mar 6, 2018
jklymak
jklymak approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll leave up in case some one else wants to check it out first.

Maybe the OSX thing should have conda at the top? People should really just use conda.

@jklymak jklymak merged commit fc73593 into matplotlib:master Mar 16, 2018
@anntzer anntzer deleted the simplify-venv-docs branch March 16, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @jklymak
0