Add some mlab alternatives #10563
Merged
Add some mlab alternatives #10563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobson
reviewed
Feb 21, 2018
lib/matplotlib/mlab.py
Outdated
|
|
||
|
|
||
| @cbook.deprecated("2.2") | ||
| @cbook.deprecated("2.2", 'numpy.mod(n, 2)') |
Member
There was a problem hiding this comment.
This isn't quite right.
From:
import numpy
from matplotlib import mlab
N = [37, 48, 64]
print('numpy:\t', list(map(lambda x: numpy.mod(x, 2), N)))
print('mlab:\t', list(map(mlab.ispower2, N)))I get:
numpy: [1, 0, 0]
mlab: [0, 0, 6]
Member
Author
There was a problem hiding this comment.
Oh yeah, that function doesn't quite do what it says on the tin (not that my alternative actually worked for determining if a number is a power of 2!)
Member
|
Are none of these used internally? If they are, they should be removed while deprecating? |
Member
|
Should already have been removed in the previous PR. |
QuLogic
approved these changes
Feb 24, 2018
Member
Author
|
Yeah, my previous big PR removed all the stuff that's deprecated from internal code. |
timhoffm
approved these changes
Feb 24, 2018
QuLogic
added a commit
that referenced
this pull request
Feb 24, 2018
Backport PR #10563 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note I've changed
nptonumpyto make things clearer. Partially solves #10382.