10000 Make ax3d.get_xlim() return a tuple, as 2D axes do. by anntzer · Pull Request #10554 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Make ax3d.get_xlim() return a tuple, as 2D axes do. #10554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2018
Merged

Make ax3d.get_xlim() return a tuple, as 2D axes do. #10554

merged 1 commit into from
Feb 25, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Feb 21, 2018 •
edited by timhoffm
Loading

PR Summary

Closes #10496. Alternate fix is in #10503.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 21, 2018
@anntzer anntzer added this to the v2.2.0 milestone Feb 21, 2018
timhoffm
timhoffm approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for making the API more consistent. This needs an API change note, as people might have relied on the np.array type.

@anntzer
Copy link
Contributor Author
anntzer commented Feb 21, 2018

done

timhoffm
timhoffm reviewed Feb 21, 2018
View reviewed changes
doc/api/next_api_changes/2018-02-21-AL.rst Outdated
``Axes3D.get_xlim``, ``get_ylim`` and ``get_zlim`` now return a tuple
`````````````````````````````````````````````````````````````````````

They previously returned an array. Returning a tupleis consistent with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: tupleis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :p

@dstansby dstansby mentioned this pull request Feb 21, 2018
Closed
dstansby
dstansby reviewed Feb 21, 2018
View reviewed changes
doc/api/next_api_changes/2018-02-21-AL.rst
@@ -0,0 +1,5 @@
``Axes3D.get_xlim``, ``get_ylim`` and ``get_zlim`` now return a tuple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go in the 2.2 API changes that has already been merged up?

@efiring efiring merged commit e188fae into matplotlib:master Feb 25, 2018
lumberbot-app bot pushed a commit that referenced this pull request Feb 25, 2018
@efiring
Backport PR #10554: Make ax3d.get_xlim() return a tuple, as 2D axes do.
41ced22
@lumberbot-app lumberbot-app bot mentioned this pull request Feb 25, 2018
Merged
@anntzer anntzer deleted the 3dlim branch February 25, 2018 22:31
tacaswell added a commit that referenced this pull request Feb 25, 2018
@tacaswell
Merge pull request #10601 from matplotlib/auto-backport-of-pr-10554
ffd4c52 
Backport PR #10554 on branch v2.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby left review comments

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

exception after clicking ok when editing axis curve info on 3d plot
5 participants
@anntzer @tacaswell @timhoffm @dstansby @efiring
0