8000 py3fy examples by anntzer · Pull Request #10528 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

py3fy examples #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

py3fy examples #10528

merged 1 commit into from
Feb 19, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Feb 19, 2018
  • Remove future imports, six, encoding cookies.
  • The pgf_examples don't actually need to be sgskipped.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby
Copy link
Member

Looks like the pgf examples are failing on circle.

@anntzer
Copy link
Contributor Author
anntzer commented Feb 19, 2018

Indeed, one of them still needs to be sgskipped.

dstansby
dstansby approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if CI passes

@anntzer
py3fy examples
a51b708 
- Remove future imports, six, encoding cookies.
- The pgf_examples don't actually need to be sgskipped.
@tacaswell tacaswell added this to the v3.0 milestone Feb 19, 2018
@dstansby dstansby merged commit f1f83f6 into matplotlib:master Feb 19, 2018
@anntzer anntzer deleted the py3examples branch February 19, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @tacaswell
0