Py3fy mathtext.py. #10520
Py3fy mathtext.py. #10520
Conversation
lib/matplotlib/mathtext.py
Outdated
| @@ -464,8 +454,9 @@ def set_canvas_size(self, w, h, d): | |||
| Set the size of the buffer used to render the math expression. | |||
| Only really necessary for the bitmap backends. | |||
| """ | |||
| self.width, self.height, self.depth = ceil(w), ceil(h), ceil(d) | |||
| self.mathtext_backend.set_canvas_size(self.width, self.height, self.depth) | |||
| self.width, self.height, self.depth = map(np.ceil, [w, h, d]) | |||
There was a problem hiding this comment.
Is this faster than np.ceil([w, h, d])?
There was a problem hiding this comment.
missed that, thanks.
lib/matplotlib/mathtext.py
Outdated
| self.width, self.height, self.depth = ceil(w), ceil(h), ceil(d) | ||
| self.mathtext_backend.set_canvas_size(self.width, self.height, self.depth) | ||
| self.width, self.height, self.depth = map(np.ceil, [w, h, d]) | ||
| self.mathtext_backend.set_canvas_size( |
There was a problem hiding this comment.
Was this too long or something?
There was a problem hiding this comment.
Was there a pep8ignored defined that can be removed now?
There was a problem hiding this comment.
there's a bunch of other long lines, let's keep that for another pr.
lib/matplotlib/mathtext.py
Outdated
| warn("Substituting with a dummy symbol.", MathTextWarning) | ||
| warnings.warn( | ||
| "Font {!r} does not have a glyph for {!a} [U+{:x}], " | ||
| "Substituting with a dummy symbol.".format( |
lib/matplotlib/mathtext.py
Outdated
| @@ -1099,7 +1091,7 @@ def __init__(self, default_font_prop): | |||
|
|
|||
| self.fonts['default'] = default_font | |||
| self.fonts['regular'] = default_font | |||
| self.pswriter = six.moves.cStringIO() | |||
| self.pswriter = cStringIO() | |||
lib/matplotlib/mathtext.py
Outdated
| .format(font.get_fontname(), sym), MathTextWarning) | ||
| warnings.warn( | ||
| "No glyph in standard Postscript font {!r} for {!r}" | ||
| .format(font.get_fontname(), sym), MathTextWarning) |
lib/matplotlib/mathtext.py
Outdated
| prev_char = s[loc-i] | ||
| if prev_char != ' ': | ||
| break | ||
| prev_char = next(c for c in s[:loc][::-1] if c != ' ') |
There was a problem hiding this comment.
It appears you need a default here.
|
comments handled |
| instead. | ||
| The following functions are deprecated: | ||
| - ``cbook.is_numlike`` (use ``isinstance(..., numbers.Number)`` instead) | ||
| - ``backend_pdf.unichr_safe`` (use ``chr`` instead) |
There was a problem hiding this comment.
Isn't that mathtext.unichr_safe?
| glue_spec = GlueSpec.factory(glue_type) | ||
| elif isinstance(glue_type, GlueSpec): | ||
| glue_spec = glue_type | ||
| else: | ||
| raise ValueError("glue_type must be a glue spec name or instance.") | ||
| raise ValueError("glue_type must be a glue spec name or instance") |
There was a problem hiding this comment.
Any particular reason for getting rid of the full stop?
There was a problem hiding this comment.
Error messages (i.e. arguments to exceptions) typically don't contain a full stop, even if they are otherwise full sentences. e.g.
In [2]: f(1)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-2-281ab0a37d7d> in <module>()
----> 1 f(1)
TypeError: f() takes 0 positional arguments but 1 was given
and Matplotlib mostly follows the same convention (no stats, just an empirical observation).
PR Summary
PR Checklist