remove string escapes from matplotlibrc.template #10421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove string escapes from matplotlibrc.template
tacaswell
approved these changes
Feb 11, 2018
jklymak
approved these changes
Feb 11, 2018
|
I don't see how this could break the docs or not pass any tests, but I won't merge in case my understanding is incorrect. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove string escapes from
matplotlibrc.template.This fixes #10406. Since the matplotlib rc file is not a python file, the rc arguments should not contain string escape characters. E.g. instead of formerly
it should read
This change makes it easier to just uncomment the lines in the template file for use in a real rc file.
Note that I left some of the arguments in the "animations" section unchanged, because it is not clear what to put there instead. In any case, the fixed version of the template allows to uncomment any rc line (including those from the animations section) and not get a warning, so I suppose the animation parameters are correct, although they contain string escapes.
PR Summary
PR Checklist