8000 Fix to allow both old and new style wx versions by BrennanGit · Pull Request #10363 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Fix to allow both old and new style wx versions #10363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2018

Conversation

BrennanGit
Copy link
Contributor

PR Summary

Apologies, I made a mistake in my previous PR #10362 and it got merged in just as I realised.
StrictVersion will fail with a value error on the old style versions like '2.8.12.0'.

This can be resolved by attempting to call StrictVersion and on failure, use a LooseVersion.
Both can be compared correctly with str("x.x.x") and the conditionals do not overlap.

I have now tested this functionality locally but am not entirely sure how I would go about writing a test to cover it in the library

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member
jklymak commented Feb 1, 2018

This is failing wx tests. Not sure if the doc build issue has anything to do with it, or is just a circleci issue.

@BrennanGit
Copy link
Contributor Author

I hope so, easy to fix a mistype. Not really sure how the docs are built here

@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Fe 9A4C b 1, 2018
@jklymak jklymak added this to the v2.2 milestone Feb 1, 2018
@jklymak jklymak merged commit 8d53ebf into matplotlib:master Feb 2, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0