8000 Linewrap backend_pgf to 79 characters. by anntzer · Pull Request #10324 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Linewrap backend_pgf to 79 characters. #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2018
Merged

Linewrap backend_pgf to 79 characters. #10324

merged 1 commit into from
Jan 26, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 26, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic
QuLogic reviewed Jan 26, 2018
View reviewed changes
lib/matplotlib/backends/backend_pgf.py Outdated
@@ -429,7 +432,8 @@ def __init__(self, figure, fh, dummy=False):
UserWarning)
self.__dict__["draw_image"] = lambda *args, **kwargs: None

def draw_markers(self, gc, marker_path, marker_trans, path, trans, rgbFace=None):
def draw_markers(
self, gc, marker_path, marker_trans, path, trans, rgbFace=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda prefer to wrap at the kwarg (dunno why this didn't comment before.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your wish is my command :p

@QuLogic QuLogic added this to the v2.2 milestone Jan 26, 2018
@QuLogic QuLogic merged commit 86083dd into matplotlib:master Jan 26, 2018
@anntzer anntzer deleted the pgf_linewrap branch January 26, 2018 08:15
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @jklymak
0