Simplify _get_xdg_cache_dir in setupext. #10247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Jan 14, 2018
setupext.py
Outdated
| return path | ||
| cache_dir = os.environ.get('XDG_CACHE_HOME') | ||
| if not cache_dir: | ||
| cache_dir = os.path.expanduser('~/.cache/matplotlib') |
There was a problem hiding this comment.
Does this work Win32? Otherwise looks good to me.
There was a problem hiding this comment.
jklymak
approved these changes
Jan 14, 2018
QuLogic
reviewed
Jan 15, 2018
| if path is not None: | ||
| path = os.path.join(path, '.cache', 'matplotlib') | ||
| return path | ||
| cache_dir = os.environ.get('XDG_CACHE_HOME') |
There was a problem hiding this comment.
Shouldn't this add matplotlib on the end?
There was a problem hiding this comment.
Well, the previous version did not, but that was arguably a bug... fixed.
setupext.py
Outdated
| <http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html>`_. | ||
| Return the XDG cache directory. | ||
|
|
||
| See http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html |
1. we don't support google app engine anymore. 2. in setupext, the cache dir is only used to cache the freetype tarball, so it's really not a huge deal if a cache dir cannot be located (this case is handled explicitly by the freetype build code).
QuLogic
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tarball, so it's really not a huge deal if a cache dir cannot be
located (this case is handled explicitly by the freetype build code).
PR Summary
PR Checklist