8000 Test timers and (a bit) key_press_event for interactive backends. by anntzer · Pull Request #10215 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Test timers and (a bit) key_press_event for interactive backends. #10215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2018
Merged

Test timers and (a bit) key_press_event for interactive backends. #10215

merged 1 commit into from
Apr 4, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 10, 2018 •
edited
Loading

PR Summary

All's in the title.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the more-interactive-tests branch 3 times, most recently from 56c505c to f81cd2b Compare January 15, 2018 07:24
@anntzer anntzer force-pushed the more-interactive-tests branch from f81cd2b to 964659e Compare March 5, 2018 02:13
@anntzer anntzer changed the title Test (a bit) key_press_event when testing interactive backends. Test timers and (a bit) key_press_event for interactive backends. Mar 18, 2018
@anntzer anntzer force-pushed the more-interactive-tests branch from 964659e to 2926881 Compare March 18, 2018 05:13
@anntzer
Copy link
Contributor Author
anntzer commented Mar 18, 2018

Can't reproduce the test failure locally :/

@anntzer anntzer force-pushed the more-interactive-tests branch 3 times, most recently from 0703180 to 4715a77 Compare March 19, 2018 07:30
@anntzer anntzer force-pushed the more-interactive-tests branch from 4715a77 to 3b555d5 Compare March 19, 2018 08:02
@anntzer
Copy link
Contributor Author
anntzer commented Mar 19, 2018

Traced the issue down to pygobject/pgi#45. Rest should work now.

@jklymak jklymak merged commit 4ac125e into matplotlib:master Apr 4, 2018
@anntzer anntzer deleted the more-interactive-tests branch April 4, 2018 18:17
@QuLogic QuLogic added this to the v3.0 milestone Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @QuLogic @jklymak
0