remove evt.Skip() from EVT_PAINT handler #10192
Conversation
|
That line of code goes back to one of the early commits (e34a333 in 2004) so we don't have a comment on why it was put there to begin with. @DietmarSchwertberger Any guesses as to why it was there? |
|
This was probaby just out of habit. For PAINT, the event is fully handled by the handler. With Skip, the handling is forwarded to the default handler which paints the grey background. No idea, why it worked at all. I would have expected that the whole widget is painted grey. The documentation does not have a Skip: P.S.: I have a feeling that it would make sense to change the whole implementation towards this: The only thing that speaks against is the comment at GraphicsContextWx: "Creating a wxGraphicsContext seems to be fairly heavy, so these objects are cached based on the bitmap object that is passed in." |
|
Is this related to #10174 ? If so, could this be a change in the wx bindings? |
|
This could be the same issue. wx did not change. I just checked the book from 2006. evt.Skip() was never supposed to be called. Not with direct paints and not with double-buffering. |
Backport PR #10192 on branch v2.1.x
PR Summary
Currently evt.Skip() is called at the end of the EVT_PAINT handler.
This should not be done and causes errors on screen when the canvas is redrawn partially, e.g. when a window is dragged over the canvas.
Strange enough, the errors don't occur always, but e.g. with "embedding_in_wx2.py" on Windows 7, 64 bit.
PR Checklist
-> not applicable