10000 Simplify pandas fixture. by anntzer · Pull Request #10178 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Simplify pandas fixture. #10178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2018
Merged

Simplify pandas fixture. #10178

merged 1 commit into from
Jan 6, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 6, 2018

PR Summary

Followup to #10124.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic
QuLogic reviewed Jan 6, 2018
View reviewed changes
lib/matplotlib/testing/conftest.py Outdated
register()
try:
yield pd
finally:
try:
from pandas.plotting import (
deregister_matplotlib_converters as deregister)
request.addfinalizer(deregister)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't you just calling it?

Copy link
Contributor Author
@anntzer anntzer Jan 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it was a typo (as in, forgot to change that)

tacaswell
tacaswell reviewed Jan 6, 2018
View reviewed changes
lib/matplotlib/testing/conftest.py Outdated
@@ -80,22 +80,21 @@ def mpl_image_comparison_parameters(request, extension):

@pytest.fixture
def pd(request):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need to take in request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope...

@QuLogic QuLogic added this to the v2.2 milestone Jan 6, 2018
@QuLogic QuLogic merged commit 32a67d3 into matplotlib:master Jan 6, 2018
@anntzer anntzer deleted the pandas-fixture branch January 6, 2018 07:34
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic
0