8000 Agg: When a single Text uses usetex, don't pass it through mathtext parser by anntzer · Pull Request #10175 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Agg: When a single Text uses usetex, don't pass it through mathtext parser #10175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2018
Merged

Agg: When a single Text uses usetex, don't pass it through mathtext parser #10175

merged 1 commit into from
Jan 6, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 5, 2018

... because the artist may have tex constructs that are not handled by
mathtext but are handled by a real tex interpreter; e.g.

plt.text(.5, .5, r"\frac12", usetex=True)

should not fail.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

8000 @anntzer anntzer added the topic: text label Jan 5, 2018
@anntzer
Agg: When a single Text uses usetex, don't pass it through mathtext p…
69aa017 
…arser.

... because the artist may have tex constructs that are not handled by
mathtext but are handled by a real tex interpreter; e.g.

    plt.text(.5, .5, r"\frac12", usetex=True)

should not fail.
@anntzer anntzer force-pushed the agg-single-artist-usetex branch from 25ab4b0 to 69aa017 Compare January 5, 2018 18:25
@tacaswell tacaswell added this to the v2.1.2 milestone Jan 6, 2018
@tacaswell tacaswell merged commit 3b3c16d into matplotlib:master Jan 6, 2018
@lumberbot-app
Copy link
lumberbot-app bot commented Jan 6, 2018

There seem to be a conflict, please backport manually

@tacaswell tacaswell modified the milestones: v2.1.2, v2.2 Jan 6, 2018
@anntzer anntzer deleted the agg-single-artist-usetex branch January 6, 2018 03:38
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: text
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @tacaswell @QuLogic
0