Use consistent float-to-str formatting for tests with units #10052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this does fix nightly. |
jklymak
approved these changes
Dec 21, 2017
anntzer
reviewed
Dec 21, 2017
lib/matplotlib/testing/jpl_units/UnitDblFormatter.py
Outdated
8000
| @@ -36,12 +36,12 @@ def __call__( self, x, pos = None ): | |||
| if len(self.locs) == 0: | |||
| return '' | |||
| else: | |||
| return str(x) | |||
| return '{:.12g}'.format(x) | |||
There was a problem hiding this comment.
Using ".12" instead of ".12g" would keep the ".0" in the test images, and perhaps avoid the need to change some of them?
There was a problem hiding this comment.
You might be right, but let's see how the nightly build feels about it.
|
Looks like we're good for Fedora 28 and a nightly build. |
QuLogic
added a commit
that referenced
this pull request
Dec 21, 2017
Backport PR #10052 on branch v2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adding explicit formatting should ensure that the resulting image is always the same. At the very least, this seems to affect Python 2 on Fedora Rawhide (which is a bit odd, TBH, since Py2 is tested on Travis) and hopefully fixes nightly builds too.
PR Checklist