8000 [MNT]: Remove examples with `test` in name and create actual tests if useful · Issue #23281 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[MNT]: Remove examples with test in name and create actual tests if useful #23281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthewfeickert opened this issue Jun 15, 2022 · 2 comments · May be fixed by #30104
Open

[MNT]: Remove examples with test in name and create actual tests if useful #23281

matthewfeickert opened this issue Jun 15, 2022 · 2 comments · May be fixed by #30104
Labels
Maintenance

Comments

@matthewfeickert
Copy link
Contributor
matthewfeickert commented Jun 15, 2022 •
edited
Loading

I suspect that these files are the remnants of the pre-nose world where the "tests" were some scripts you ran to see if they worked so they really were written to be tests. Not sure if they were accidentally or intentionally not migrated to units tests when nose was adopted?

It looks like evans_test.py came in to being via f2a0c7a , I strongly suggest this was an example suggest by some with some part of the name as Evan or Evans. Searching discourse from about that time gets https://discourse.matplotlib.org/t/bar-plot-forget-units-information/7884 which will not quite the same, suggests that a James Evans was interested in units in ~2007 so it is plausible the file is named after their needs!

I think the comprise I would prefer here is to rename the files (to make pytest happy) but leave the headings as they are (to be as clear as we have currently been) about what these files are actually for.

Originally posted by @tacaswell in #23219 (comment)
@matthewfeickert
Copy link
Contributor Author

Now that PR #23219 is in, this can move forward as a follow up to Issue #23214.

@matthewfeickert matthewfeickert changed the title Remove examples with test in name and create actual tests if useful [MNT]: Remove examples with test in name and create actual tests if useful Jun 17, 2022
@matthewfeickert
Copy link
Contributor Author

@greglucas for tracking purposes, can I get you to label this as Maintenance?

@livlutz livlutz linked a pull request May 24, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename evans_test.py example for Foo units class and conversion livlutz/matplotlib
2 participants
@matthewfeickert @oscargus
0