8000 [MNT]: Rename examples with "test" in the name · Issue #23214 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[MNT]: Rename examples with "test" in the name #23214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greglucas opened this issue Jun 7, 2022 · 2 comments · Fixed by #23219
Closed

[MNT]: Rename examples with "test" in the name #23214

greglucas opened this issue Jun 7, 2022 · 2 comments · Fixed by #23219
Labels
Maintenance
Milestone
v3.6.0

Comments

@greglucas
Copy link
Contributor

Summary

Some example files have "something_test.py" in their name which can be picked up as tests and isn't really a clear example name. These could probably be renamed.

Identified in: #23130

Example of a poor name: https://github.com/matplotlib/matplotlib/blob/main/examples/scales/log_test.py

cc: @matthewfeickert

Proposed fix

Update all non-test files with "test" in their name to something else.
@matthewfeickert
Copy link
Contributor

Thanks for taking the time for write this up @greglucas! I'll put it on the docket for tomorrow. 👍

@matthewfeickert
Copy link
Contributor

As of 8e2987b there are only 4 .py files that match the problematic pattern

$ find examples/ -type f -iname "*test*.py"
examples/scales/log_test.py
examples/text_labels_and_annotations/usetex_baseline_test.py
examples/units/evans_test.py
examples/units/artist_tests.py

so this should be easy to cleanup.

@matthewfeickert matthewfeickert mentioned this issue Jun 8, 2022
Merged
1 task
@matthewfeickert matthewfeickert mentioned this issue Jun 15, 2022
Open
@QuLogic QuLogic added this to the v3.6.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging a pull request may close this issue.

MNT: Rename example files with 'test' in name matthewfeickert/matplotlib
3 participants
@QuLogic @matthewfeickert @greglucas
0