8000 Cibuild built from sdist -> wheel by cvanelteren · Pull Request #622 · matplotlib/basemap · GitHub
[go: up one dir, main page]
Skip to content

Cibuild built from sdist -> wheel #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 12, 2025
Merged

Cibuild built from sdist -> wheel #622

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1d489e5
flow sdist->wheel
cvanelteren Feb 26, 2025
b86db26
build data packages directly
cvanelteren Feb 26, 2025
8db731f
attempt fix install windows
cvanelteren Feb 26, 2025
026ceea
update verification step
cvanelteren Feb 26, 2025
76ed633
simplify verification
cvanelteren Feb 26, 2025
a7d3e33
Merge remote-tracking branch 'upstream/develop' into cibuild-built-fr…
molinav Jun 12, 2025
dcc6ddc
Remove unneeded sdist verification
molinav Jun 12, 2025
fef1d4d
Remove redundant comment
molinav Jun 12, 2025
2dccf02
Move download basemap sdist step right before extraction
molinav Jun 12, 2025
26cbb8c
Rename dist artifacts more consistently
molinav Jun 12, 2025
f697081
Update build_wheels job name description
molinav Jun 12, 2025
0fd2ca9
Update debugging message
molinav Jun 12, 2025
5ad73ea
Add missing quotes
molinav Jun 12, 2025
ddd869f
Update CHANGELOG
molinav Jun 12, 2025
b06507b
Homogenise code in CI bifurcated steps
molinav Jun 12, 2025
2e196f5
Extend comment about usage of extracted sdist with cibuildwheel
molinav Jun 12, 2025
8000
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
attempt fix install windows
  • Loading branch information
@cvanelteren
cvanelteren committed Feb 26, 2025
commit 8db731f3bfdb1f4353771a190fe0241c0d32f76e
17 changes: 5 additions & 12 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ jobs:

# Verify they're installed
python -c "import mpl_toolkits.basemap_data; print('Data package installed')"
python -c "import mpl_toolkits.basemap_data_hires; print('Hires data package installed')" || echo "Optional hires package not installed"

# Install the data packages (Windows)
- name: Install data packages (Windows)
Expand All @@ -124,18 +123,12 @@ jobs:
python -m pip install $wheel.FullName
}

# Verify they're installed
try {
python -c "import mpl_toolkits.basemap_data; print('Data package installed')"
} catch {
Write-Host "Error importing basemap_data"
}
# Show installed packages
python -m pip list | Select-String "mpl_toolkits.basemap"

try {
python -c "import mpl_toolkits.basemap_data_hires; print('Hires data package installed')"
} catch {
Write-Host "Optional hires package not installed"
}
# Try different import paths
Write-Host "Trying to import basemap_data..."
python -c "import mpl_toolkits.basemap_data; print('mpl_toolkits.basemap_data imported successfully')"

- name: Extract sdist (Linux/macOS)
if: runner.os != 'Windows'
Expand Down
0