Brands renaming #8109
Open
Brands renaming #8109
+402
−412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 21, 2025 21:13
Collaborator
|
@sgiehl I've reviewed the changes, all are fine for me. @sanchezzzhak if you can take a second look please? |
Contributor
Author
|
Fails on composer don't think this was caused by me 😅 |
sanchezzzhak
requested changes
Jan 27, 2026
| - regex: 'Cherry(?:[ _]?Mobile)?[ _]?([^/;]+)(?: Build|[);])' | ||
| model: '$1' | ||
|
|
||
| #Previously listed as "White Mobile" brand, but based on https://firmwarefile.com/cherry-mobile-omega-lite-3, https://forum.gsmhosting.com/vbb/f296/cherry-mobile-omega-lite-3-frp-remove-2259709/ and https://deviceatlas.com/device-data/devices/white-mobile/am1010v/30376111 (and others), this is likely "Cherry Mobile", especially since I was not able to find any evidence of "White Mobile" ever existing. |
Collaborator
There was a problem hiding this comment.
Remove this comment
Cherry Mobile should stay with the old name.
https://www.gadgetpilipinas.net/2016/12/cherry-mobile-defender/
The AM1010V can be separated into a separate brand.
Contributor
Author
There was a problem hiding this comment.
But I did not change name for Cherry Mobile. What do you mean?
Are you suggesting we keep White Mobile for AM1010V?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Split from #8096 this covers brand name changes, that are mostly more than just addition of a prefix or otherwise more contentious
Review