8000 Update autocomplete to enable cache and return most recent requests by vwbusguy · Pull Request #769 · matiasdelellis/facerecognition · GitHub
[go: up one dir, main page]

Skip to content

Update autocomplete to enable cache and return most recent requests#769

Open
vwbusguy wants to merge 3 commits intomatiasdelellis:masterfrom
vwbusguy:feature/optimize-autocomplete
Open

Update autocomplete to enable cache and return most recent requests#769
vwbusguy wants to merge 3 commits intomatiasdelellis:masterfrom
vwbusguy:feature/optimize-autocomplete

Conversation

@vwbusguy
Copy link
@vwbusguy vwbusguy commented Aug 1, 2024

This adds two things to the AutoComplete instantiations:

  • cache - this is a minimal benefit, but still means less db queries if someone uses backspace and re-types something
  • adds a simple query counter so that older query results from slower database transactions don't overwrite newer ones

Fixes #766

Tested this in my local Nextcloud (29.0.4) with dev tools in Firefox 128.0.

Signed-off-by: Scott A. Williams <vwbusguy@fedoraproject.org>
@matiasdelellis
Copy link
Owner

Hi @vwbusguy
Tomorrow I hope to be able to do a review. 😬

@vwbusguy
Copy link
Author
vwbusguy commented Sep 5, 2024

Hi @vwbusguy
Tomorrow I hope to be able to do a review. 😬

For what it's worth, I'll be at the Nextcloud Community/Contributors conference in Berlin in about a week. If you'll be there, I'm happy to review this with you there.

@vwbusguy
Copy link
Author

Back merged since the nc30 PR update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete slower earlier queries redraw over newer ones

2 participants

0