E55D Fix StocksEquitiesDailyOpenCloseApiResponse type mappings by suremarc · Pull Request #70 · massive-com/client-python · GitHub
[go: up one dir, main page]
Skip to content

Fix StocksEquitiesDailyOpenCloseApiResponse type mappings#70

Merged
suremarc merged 1 commit intomasterfrom
fix-open-close
May 9, 2021
Merged

Fix StocksEquitiesDailyOpenCloseApiResponse type mappings#70
suremarc merged 1 commit intomasterfrom
fix-open-close

Conversation

@suremarc
Copy link
Contributor
@suremarc suremarc commented May 9, 2021

A previous update to the Swagger code created a bug due to the wrong names being put into the type mappings in StocksEquitiesDailyOpenCloseApiResponse under the REST models. See #69.

After running the updated version of the client, I am able to run the user's code successfully:

    with RESTClient(os.environ['API_KEY']) as client:
        resp = client.stocks_equities_daily_open_close("AAPL", "2018-03-02")
        print(f"On: {resp.from_} Apple opened at {resp.open} and closed at {resp.close}")

Result:

On: 2018-03-02 Apple opened at 43.2 and closed at 44.0525

@suremarc suremarc requested review from jbonzo and jcho-polygon May 9, 2021 14:44
@suremarc suremarc merged commit 1509ddd into master May 9, 2021
@suremarc suremarc deleted the fix-open-close branch May 9, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbonzo jbonzo jbonzo approved these changes

@jcho-polygon jcho-polygon Awaiting requested review from jcho-polygon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suremarc @jbonzo
0