include date param in get_ticker_details#321
Merged
clickingbuttons merged 1 commit intomassive-com:masterfrom Oct 31, 2022
Merged
include date param in get_ticker_details#321clickingbuttons merged 1 commit intomassive-com:masterfrom
clickingbuttons merged 1 commit intomassive-com:masterfrom
Conversation
clickingbuttons
approved these changes
Oct 31, 2022
Contributor
|
Released in v1.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320
I put a second assert in the same test method, but happy to factor the expected response data out and create a second test method, if you prefer to follow the "one assertion per test" paradigm