8000 [MRG] Pass the dtype consistency & accuracy tests for ridge by ncordier · Pull Request #4 · massich/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Pass the dtype consistency & accuracy tests for ridge #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 8, 2017
Merged

[MRG] Pass the dtype consistency & accuracy tests for ridge #4

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3833817
Allows 32-bit dtype consistency if solver is svd
ncordier Jun 8, 2017
28a2cff
Pass the consistency test for ridge with 32-bit dtype input
ncordier Jun 8, 2017
87a4a91
Typo fixed
ncordier Jun 8, 2017
1f2a9c0
Add sparse_cg to the list of solvers to test for dtype consistency
ncordier Jun 8, 2017
daf695e
Allows 32-bit dtype consistency if solver is sparse_cg
ncordier Jun 8, 2017
6c924dc
Add cholesky to the list of solvers to test for dtype consistency
ncordier Jun 8, 2017
2b93657
Add lsqr to the list of solvers to test for dtype consistency
ncordier Jun 8, 2017
6004808
Allows 32-bit dtype consistency if solver is lsqr
ncordier Jun 8, 2017
8899064
Make sure dtype consistency is ensured if solver is cholesky_kernel (…
ncordier Jun 8, 2017
3b10043
Updated list of solvers which have been tested
ncordier Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allows 32-bit dtype consistency if solver is sparse_cg
  • Loading branch information
@ncordier
ncordier committed Jun 8, 2017
commit daf695e1580b719c68c7e47a2b23f90d75fb7a9c
2 changes: 1 addition & 1 deletion sklearn/linear_model/ridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
def _solve_sparse_cg(X, y, alpha, max_iter=None, tol=1e-3, verbose=0):
n_samples, n_features = X.shape
X1 = sp_linalg.aslinearoperator(X)
coefs = np.empty((y.shape[1], n_features))
coefs = np.empty((y.shape[1], n_features), dtype=X.dtype)

if n_features > n_samples:
def create_mv(curr_alpha):
Expand Down
0