8000 Normalize hyphens in env source · Issue #60 · markusressel/container-app-conf · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize hyphens in env source #60

Closed
markusressel opened this issue Apr 15, 2021 · 0 comments · Fixed by #61
Closed

Normalize hyphens in env source #60

markusressel opened this issue Apr 15, 2021 · 0 comments · Fixed by #61
Assignees
@markusressel
Labels
enhancement New feature or request

Comments

@markusressel
Copy link
Owner

The current KEY_PATH_REGEX allows both hyphens and underscores. As brought up in markusressel/keel-telegram-bot#29 hyphens are not POXIS compliant.

Solution

Normalize hyphens to underscores in the env source and check for both the original and normalized version to avoid a breaking change.
@markusressel markusressel added the enhancement New feature or request label Apr 15, 2021
@markusressel markusressel self-assigned this Apr 15, 2021
@markusressel markusressel mentioned this issue Apr 15, 2021
Merged
markusressel added a commit that referenced this issue Apr 15, 2021
@markusressel
Feature/#60 normalize hyphens (#61)
7aebc0a 
* updated Pipfile.lock

* check for both original and normalized keys and get whichever is found first

* added test for env source

* updated README

* dont advertise the backwards compatible stuff in the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markusressel markusressel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#60 normalize hyphens markusressel/container-app-conf
1 participant
@markusressel
0