Fixed CVE-2023-2318 DOM-based XSS in MarkText bug #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: Seems like my fix won't allow for link pasting now that I've just tried it. I'll have to see what is happening with that. |
Limatucano
reviewed
Jun 13, 2023
| @@ -116,7 +116,7 @@ const pasteCtrl = ContentState => { | |||
| link.innerHTML = sanitize(title, PREVIEW_DOMPURIFY_CONFIG, true) | |||
| } else { | |||
| const span = document.createElement('span') | |||
| span.innerHTML = text | |||
| span.innerHTML = sanitize(title, PREVIEW_DOMPURIFY_CONFIG, true) | |||
There was a problem hiding this comment.
One question: shouldn't the text where the title is? for example sanitize(text, PREVIEW_DOMPURIFY_CONFIG, true)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ticket #3618 there was a DOM-based XSS which allowed "arbitrary JavaScript code to run in the context of MarkText main window." (quoted from @chromium1337, the author of ticket #3618), I also updated caniuse-lite while getting the build to work, not exactly sure what that does; but there you go! 😁
It's my first proper pull request to an open source project! I hope I've done everything right. Very happy to finally do a bug fix! :D 🥳
Edit: Seems like my fix won't allow for link pasting now that I've just tried it. I'll have to see what is happening with that.