Fix HTML comment blocks in list items (issue #1144) #1146
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow outdented empty lines to remain inside HTML blocks when parsing list items, and add a regression fixture for issue markdown-it#1144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-->#1144.Details
The HTML block parser currently ends when it sees an outdented line. Inside list items, blank lines can be outdented but still belong to the list item, which causes
<!-- ... -->blocks to end before-->. This change allows empty lines to remain inside HTML blocks when parsing list items, matching CommonMark’s type 2 rules.Testing