#2837 Add support for text blocks in expressions#2872
Merged
filiphr merged 1 commit intomapstruct:masterfrom Jun 18, 2022
Merged
#2837 Add support for text blocks in expressions#2872filiphr merged 1 commit intomapstruct:masterfrom
filiphr merged 1 commit intomapstruct:masterfrom
Conversation
sjaakd
reviewed
Jun 15, 2022
processor/src/main/java/org/mapstruct/ap/internal/model/source/MappingOptions.java
Show resolved
Hide resolved
sjaakd
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Java Text Blocks by changing the pattern we use to match an expression to use the
DOTALLflag (dot matches new lines) and also adding extra whitespaces beforejavaand after the closing of the expression. The extra whitespaces are there because a user might make a mistake when typing the expression and have leading whitespace in the string. We don't want to be too strict there.Fixes #2837