8000 [WEB-5029]chore: updates icons for title and description by vamsikrishnamathala · Pull Request #7862 · makeplane/plane · GitHub
[go: up one dir, main page]
Skip to content

[WEB-5029]chore: updates icons for title and description #7862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: preview
Choose a base branch
from
Open

[WEB-5029]chore: updates icons for title and description #7862

wants to merge 1 commit into from
+4 −4

Conversation

vamsikrishnamathala
Copy link
Member
@vamsikrishnamathala vamsikrishnamathala commented Sep 26, 2025 •
edited by coderabbitai bot
Loading

Description

This update changes the Icons for activity of Title update and Description update in work items.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

  • Style
    • Updated the icon in Issue Description activity from a speech bubble to a text-alignment icon for clearer semantics.
    • Updated the icon in Issue Name activity from a speech bubble to a “Type” icon to better reflect naming.
    • Sizes and accessibility attributes remain unchanged.
    • No functional or behavioral changes; purely visual refinements to improve clarity in the issue activity feed.

@vamsikrishnamathala vamsikrishnamathala self-assigned this Sep 26, 2025
@vamsikrishnamathala vamsikrishnamathala added the 🌟enhancement New feature or request label Sep 26, 2025
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Sep 26, 2025 •
edited
Loading

Walkthrough

Updated icons in two issue activity action components: description now uses AlignLeft; name now uses Type. Imports and icon props were adjusted accordingly. No changes to logic, props, or public interfaces.

Changes

Cohort / File(s) Change Summary
Icon updates for issue activity actions
apps/web/core/components/issues/issue-detail/issue-activity/activity/actions/description.tsx, apps/web/core/components/issues/issue-detail/issue-activity/activity/actions/name.tsx		 Swapped lucide-react icons: MessageSquare -> AlignLeft (description), MessageSquare -> Type (name). Updated imports and passed icons; no other logic or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

🧹chore, 🌐frontend

Suggested reviewers

  • sriramveeraghanta
  • anmolsinghbhatia
  • prateekshourya29

Poem

A bunny blinked at icons bright,
Swapped squares for lines—now left feels right.
A tap, a hop, no code upheaval,
Just tidier glyphs for user approval.
Thump-thump! the sprint goes light. 🐇✨

Pre-merge checks and finishing touches

8000 ✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title accurately summarizes the primary change by indicating an update to the icons for title and description activities and includes the relevant ticket reference, making it clear and specific to the changeset.
Description Check ✅ Passed The description follows the repository template with a clear “Description” section and a checked improvement type, and all required headings are present; while screenshots, test scenarios, and references are not provided they are non-critical for this UI icon change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-activity_icons
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bedc1fa and cfa8c83.

📒 Files selected for processing (2)
  • apps/web/core/components/issues/issue-detail/issue-activity/activity/actions/description.tsx (2 hunks)
  • apps/web/core/components/issues/issue-detail/issue-activity/activity/actions/name.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Build and lint web apps
  • GitHub Check: Analyze (python)
🔇 Additional comments (2)
apps/web/core/components/issues/issue-detail/issue-activity/activity/actions/description.tsx (1)

3-24: Icon swap aligns with intent

AlignLeft is part of lucide-react’s standard set and better conveys a description/body edit; the props stay consistent with our existing pattern, so this is good.

apps/web/core/components/issues/issue-detail/issue-activity/activity/actions/name.tsx (1)

3-24: Updated name icon looks correct

Type provides the right visual cue for title changes and keeps size/accessibility attributes unchanged. Looks good.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@makeplane MakePlane
Copy link
makeplane bot commented Sep 26, 2025

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolsinghbhatia anmolsinghbhatia Awaiting requested review from anmolsinghbhatia

At least 1 approving review is required to merge this pull request.

Assignees

@vamsikrishnamathala vamsikrishnamathala

Labels
🌟enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vamsikrishnamathala
0