Update readme for similar format to other Mailtrap SDKs #79
Conversation
| Email API: | ||
| - Full email sending – [`full.rb`](examples/full.rb) | ||
|
|
||
| ### Content-Transfer-Encoding |
There was a problem hiding this comment.
So you simply removed a chunk of documentation. Maybe it should be moved somewhere instead?
There was a problem hiding this comment.
I see, my idea was that if other libs are not utilizing these points, it means these points were suppressed on its way to our SDK documentation formats. These 2 paragraphs 'Content-Transfer-Encoding' and 'Multiple Mailtrap Clients' are not existing in other major libraries while they absolutely make same sense to be there.
Do you vote for me to keep them?
There was a problem hiding this comment.
Yeah lets keep them. Those chapters were added to address customer requests. I dont see the value in removing the documentation. If your goal is to unify the structure, please do that and keep the existing docs.
|
The PR description is probably not up to date. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
Changes
README.md