magento/magento2#39959 catalog_product_save_before observer throws date-related error when using REST API without store-level values (getFinalPrice() issue) #40003
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d error when using REST API without store-level values (getFinalPrice() issue) Adjusted the processing of `SpecialFromDate` to ensure proper formatting when the date is provided as a `DateTimeInterface` instance. This prevents errors arising during `getFinalPrice()` execution under certain scenarios.
|
Hi @KrasnoshchokBohdan. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run all tests |
…d error when using REST API without store-level values (getFinalPrice() issue) Updated special price logic to ensure date formats are handled consistently when calculating and setting the "special from" date. This improves compatibility and prevents potential type issues with date-related operations.
|
@magento run all tests |
…d error when using REST API without store-level values (getFinalPrice() issue) - fix static test errors
|
@magento run all tests |
|
@magento run Unit Tests |
|
@magento run all tests |
engcom-Hotel
requested changes
Jul 17, 2025
There was a problem hiding this comment.
Hello @KrasnoshchokBohdan,
Thanks for the contribution!
The changes seems good to us, but some suggestion as follows:
- The PR changes can be covered by unit and integration tests. A test should verify that setting a special price via API or admin behaves correctly.
- Add inline comments to explain the rationale behind formatting
special_from_date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the processing of
SpecialFromDateto ensure proper formatting when the date is provided as aDateTimeInterfaceinstance. This prevents errors arising duringgetFinalPrice()execution under certain scenarios.Description (*)
I focused on investigation error
TypeError: strtotime(): Argument #1 ($datetime) must be of type string, DateTime given in lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php:275the reason for it must be
\Magento\Catalog\Observer\SetSpecialPriceStartDate::execute
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
payload
{ "product": { "sku": "testing-special-date", "price": 120, "status": 0, "visibility": 4, "type_id": "simple", "extension_attributes": { "stock_item": { "stock_id": 1, "qty": 207, "is_in_stock": true } }, "custom_attributes": [ { "attribute_code": "tax_class_id", "value": "2" }, { "attribute_code": "special_price", "value": "100.00" } ] }, "saveOptions": true }Questions or comments
Contribution checklist (*)