8000 Suggestions: second are lost in default date serialization + XML test broken by romain-dartigues · Pull Request #32 · madzak/python-json-logger · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 21, 2024. It is now read-only.

Suggestions: second are lost in default date serialization + XML test broken #32

Merged
merged 2 commits into from
Jun 12, 2016
Merged

Suggestions: second are lost in default date serialization + XML test broken #32

merged 2 commits into from
Jun 12, 2016

Conversation

romain-dartigues
Copy link

Hi,

here are some suggestions:

  • in the current default JSON serializer, seconds are lost in datetime instances
  • in my opinion, the datefmt parameter to logging.Formatter instances should be used only to format the message time; not to serialize the data
  • testJsonLogger has been renamed to TestJsonLogger

Regards.

Romain Dartigues added 2 commits March 2, 2016 09:48
ISO format all date/time objects by default
4c655a0 
* the `datefmt` parameter is intended to be used
  by logging.Formatter.formatTime and not for the serialization
* seconds are lost in the serialization of time and datetimes instances
xml test broken
b789183 
Fix typo introduced in b13299c when "testJsonLogger" was renamed in
"TestJsonLogger" but not in the called test.
@madzak madzak merged commit 6425c16 into madzak:master Jun 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romain-dartigues @madzak
0