8000 Change type of multicast_id from int to uint64 by tobiasKaminsky · Pull Request #8 · maddevsio/fcm · GitHub
[go: up one dir, main page]
Skip to content

Change type of multicast_id from int to uint64 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

Change type of multicast_id from int to uint64 #8

merged 1 commit into from
Nov 28, 2018

Conversation

tobiasKaminsky
Copy link
Contributor

With using this library we get an error on unmarshalling multicast_id to int, like this

Sending the notification failed: json: cannot unmarshal number 5618853696839826700 into Go struct field Response.multicast_id of type int

This PR changes is to use unsigned int which is capable to fit the large number.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.603% when pulling 0bf5bd2 on tobiasKaminsky:master into 87fdfd7 on maddevsio:master.

@coveralls
Copy link
coveralls commented Nov 26, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 74.603% when pulling 9dc920a on tobiasKaminsky:master into 87fdfd7 on maddevsio:master.

@tobiasKaminsky
Change int to uint64
9dc920a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nickvergessen
Copy link
nickvergessen commented Nov 28, 2018 •
edited
Loading

👍 fixes issues when sending messages via FCM

@gen1us2k gen1us2k merged commit 4130b76 into maddevsio:master Nov 28, 2018
@gen1us2k
Copy link
Contributor

Thanks

@nickvergessen
Copy link

Can you release a new version to gopkg.in? Thanks 😅

@gen1us2k
Copy link
Contributor

v1.0.4 has been released.

6A58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasKaminsky @coveralls @nickvergessen @gen1us2k
0