[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make uv.kill's signum optional #668

Merged
merged 1 commit into from
Aug 22, 2023
Merged

docs: make uv.kill's signum optional #668

merged 1 commit into from
Aug 22, 2023

Conversation

Bilal2453
Copy link
Contributor
@Bilal2453 Bilal2453 commented Aug 22, 2023 •
edited
Loading

same as #666 for the same reasons.

See

luv/src/process.c

Lines 319 to 324 in 9e3c232

static int luv_kill(lua_State* L) {
int pid = luaL_checkinteger(L, 1);
int signum = luv_parse_signal(L, 2);
int ret = uv_kill(pid, signum);
return luv_result(L, ret);
}

@squeek502
Copy link
Member

CI failure is unrelated: #669

@squeek502 squeek502 merged commit 317b150 into luvit:master Aug 22, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeek502 squeek502 squeek502 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilal2453 @squeek502