-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.45 #649
V1.45 #649
Conversation
* LuaJIT v2.1 to HEAD * libuv v1.x to v1.45.0
See #646 (comment) |
28292f9
to
763f07e
Compare
Ok, change finished. |
Created a pull request with the remaining stuff: zhaozg#5 |
…taffinity, thread_getcpu bindings
These functions are public but currently undocumented. Will wait to bind them until they have documentation.
Good jobs, Let wait appveyor report status. |
failed https://ci.appveyor.com/project/racker-buildbot/luv/builds/47095901
|
Strange, will figure that out in a bit. I'm currently on Linux reporting the valgrind libuv stuff 😄 |
Maybe lua cast it as signed number on 32 bits arch. I do some check. |
Looks like you're right. Changing |
Looks like I think |
ok, I will back in 20 minutes, outsides now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bad bug in the code I wrote, will submit a fix in a few minutes.
… of `uv_thread_t*` This happened to work since the uv_thread_t is at the start of the luv_thread_t structs so their pointers happen to be equal, but it's definitely worth fixing.
'Dbghelp'; | ||
"Ole32"; | ||
"Shell32"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close #646