Pre-commit.ci test #2
Conversation
| Warnings | |
|---|---|
|
Some issues found for the commit messages in this PR:
Please fix these commit messages - here are some basic tips:
|
| Messages | |
|---|---|
| 📖 | You might consider squashing your 4 commits (simplifying branch history). |
👋 Hello lucasssvaz, we appreciate your contribution to this project!
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
4515d1d to
8bdc3d0
Compare
|
Adding dummy non-formatted file to test. |
|
Looks ok. Adding another dummy file. |
|
Looks OK. Changing the style updates old files as well. Testing adding mixed file types and changing already existing files. |
|
C/C++ files looks ok. Black cannot always fix everything by itself (for example in dummy.py). When adding the python linter we will need to adjust some files manually. For files it can't fix, the CI will fail and show in the log where formatting errors were detected. Testing codespell. |
c2eb6fd to
a1628df
Compare
|
Codespell works fine. Just need to be careful with false positives when updating the codebase by locally disabling the write flag and adding the false positives to the config file. |
1451bf0 to
5e32c38
Compare
|
Separated codespell config into a new file to make it more intuitive. Also delete pyproject and move black config as hook argument (as it was just one option). Need to investigate prettier and yamllint. |
d81b7c9 to
240ac9a
Compare
|
Prettier and yamllint looks properly configured. Testing in the entire codebase to check for any potential issues. |
807aad0 to
6a4d292
Compare
5f3384a to
69f551e
Compare
69f551e to
30f0e98
Compare
Testing of pre-commit.ci lite. Configured to run only in modified files.