This repository was archived by the owner on May 10, 2018. It is now read-only.
[DM-10133] Update github3.py protection API. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new GitHub v3 branches protection API has been updated. This implements the current documented API. See: https://developer.github.com/v3/repos/branches/ https://developer.github.com/changes/2017-03-22-protected-branches-admin-improvements/ https://developer.github.com/changes/2017-04-11-protected-branch-dismissal-restrictions/ * Update :class:`Branch <github3.repos.branch.Branch>`. [X] Make protection a method. [X] Update `protect`. [X] Update `unprotect`. * Add :class:`Protection <github3.repos.branch.Protection>`. [X] Get branch protection [X] Update branch protection [X] Remove branch protection (delete) [X] Get required status checks of protected branch [X] Get pull request review enforcement of protected branch [X] Get admin enforcement of protected branch [X] Get restrictions of protected branch * Add :class:`RequiredStatusChecks <github3.repos.branch.RequiredStatusChecks>` [X] Update required status checks of protected branch [X] Remove required status checks of protected branch (delete) [X] List required status checks contexts of protected branch [X] Replace required status checks contexts of protected branch [X] Add required status checks contexts of protected branch [X] Remove required status checks contexts of protected branch (delete_contexts) * Add :class:`RequiredPullRequestReviews <github3.repos.branch.RequiredPullRequestReviews>` [X] Update pull request review enforcement of protected branch [X] Remove pull request review enforcement of protected branch (delete) * Add :class:`EnforceAdmins <github3.repos.branch.EnforceAdmins>` [X] Add admin enforcement of protected branch [X] Remove admin enforcement of protected branch * Add :class:`Restrictions <github3.repos.branch.Restrictions>` [X] Remove restrictions of protected branch [X] List team restrictions of protected branch [X] Replace team restrictions of protected branch [X] Add team restrictions of protected branch [X] Remove team restrictions of protected branch [X] List user restrictions of protected branch [X] Replace user restrictions of protected branch [X] Add user restrictions of protected branch [X] Remove user restrictions of protected branch modified: github3/repos/branch.py
athornton
approved these changes
Apr 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new GitHub v3 branches protection API has been updated. This implements the current documented API.
See Also
https://developer.github.com/changes/2017-03-22-protected-branches-admin-improvements/
https://developer.github.com/changes/2017-04-11-protected-branch-dismissal-restrictions/
Update
Branch <github3.repos.branch.Branch>.protect.unprotect.Add
Protection <github3.repos.branch.Protection>.Add
RequiredStatusChecks <github3.repos.branch.RequiredStatusChecks>Add
RequiredPullRequestReviews <github3.repos.branch.RequiredPullRequestReviews>Add
EnforceAdmins <github3.repos.branch.EnforceAdmins>Add
Restrictions <github3.repos.branch.Restrictions>TODOs
Tests
Push LSST SQuaRE version
sqre-github3.pylsst-sqre/github3.pyPush Upstream
Create or find issue.
Fixup branch and PR.
Add name to AUTHORS.
modified: github3/repos/branch.py