8000 Add gzip_pattern config option by blangenfeld · Pull Request #168 · logstash-plugins/logstash-input-s3 · GitHub
[go: up one dir, main page]
Skip to content

Add gzip_pattern config option #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2020
Merged

Add gzip_pattern config option #168

merged 4 commits into from
Mar 17, 2020

Conversation

blangenfeld
Copy link
Contributor
@blangenfeld blangenfeld commented Nov 29, 2018 •
edited by kares
Loading

Just happened to run into the same problem as #165, as we're working with files named e.g. data.json.gz.1, data.json.gz.2.

resolves #165

@blangenfeld
Copy link
Contributor Author

Two of four build jobs are failing, but I don't think it has anything to do with the PR.

https://travis-ci.org/logstash-plugins/logstash-input-s3/jobs/461470503#L722

<======-------> 47% EXECUTING [56s]> :logstash-core:compileJava > Resolve dependencies :logstash-core:compileClasspath > log4j-2.9.1.pom > 13 KB/54 KB downloadedFAILURE: Build failed with an exception.
* What went wrong:
Could not resolve all files for configuration ':logstash-core:compileClasspath'.
> Could not resolve org.apache.logging.log4j:log4j-api:2.9.1.

@blangenfeld blangenfeld mentioned this pull request Nov 29, 2018
Closed
jsvd
jsvd reviewed Dec 4, 2018
View reviewed changes
Copy link
Member
@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are OK, can you add the documentation about the new option to the docs/index.asciidoc file?

@blangenfeld
Copy link
Contributor Author

Done! 👍

@blangenfeld
Copy link
Contributor Author

@jsvd , is the PR good to go and looking good to you guys? I'd love to ditch our private fork. 😅

@JoshiiSinfield
Copy link

HI,

We're encountering this, and would love to see it merged soon!

Cheers,
Josh

@gurupritmukhraiya
Copy link

Any updates?

@ghost
Copy link
ghost commented Jul 23, 2019 •
edited by ghost
Loading

Hi @jsvd ,
When can we see this merged? Facing the same issue and would love to see this merged.
Any estimates/timeline?

thanks,

kares
kares approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor
@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good

@kares kares merged commit ad7e535 into logstash-plugins:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd left review comments

@kares kares kares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional flag to decompress file without having 'gz' extention
5 participants
@blangenfeld @JoshiiSinfield @gurupritmukhraiya @jsvd @kares
0