fix: add card hashtag to line without property #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c12d41
to
1a8d690
Compare
|
Rebased and moved comments to docstring, move regex explanation to commit message after looking at other PR conventions. |
e53b589
to
5041641
Compare
Use a RegEx to append #card to lines without properties: '(?m)' for multiline, '(?<!::.*)' to skip properties, ' ?' for optional space, '$' for end of line.
5041641
to
98147c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9380
I neglected to add the suggested workaround for property-only blocks as I noticed the same issue occurs with e.g. /H1 command, which will add # to the property in the first line of a block; so this should probably be handled elsewhere in a more generic way.
Testing Video