-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: macro rendered result has unnecessary right margin [breaking change] #9234
base: master
Are you sure you want to change the base?
Conversation
Whooh... you are right. No custom css and theme inductions (even cache was cleared) but there was a plugin that provide styles. Good point for me: plugins can change style too. I've add So there are two changes here:
WRONG: :macros {
"theme-test-macro1" "[:b \"macro\"]",
"theme-test-macro2" "macro",
"theme-test-macro3" "header\nmacro",
} - before {{theme-test-macro1}} after
- before {{theme-test-macro2}} after
- before {{theme-test-macro3}} after |
Thanks for the instructions.
This is a breaking change. I don't use macros enough to have an opinion on this so will defer to others on the team |
@logseq-cldwalker sure, thank you 🙏! Please, consider this discussions: |
@logseq-cldwalker, update PR to left default rendering behavior for macros with headings. So, now it changes only one-liner macros. |
Just found an issue I've fixed in this PR: #8623 |
Found additional case for iframe (described here). So I've changed the display style of macro-div ( Updated first post to keep all summary information about changes. This comment is for history reasons. |
16115db
to
db52beb
Compare
I've added styles to leverage one-liner macros. Fixes #8623
NOTE: This message is a summary and was updated. In the comments below you can find a history of all the changes during working on this PR.
Changes:
.inline
class).inline
class).mr-1
).inline
class)Test data
- before {{theme-test-macro0}} after - before {{theme-test-macro1}} after - before {{theme-test-macro2}} after - before {{theme-test-macro3}} after - {{iframe https://wikipedia.com}} ;; iframe should be as wide as Logseq block
Related discussions