[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugins local browser #11406

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: plugins local browser #11406

wants to merge 4 commits into from

Conversation

bugfest
Copy link
@bugfest bugfest commented Jul 3, 2024

This PR implements a way to enable plugins in browser for self-hosted LogSeq deployments. It loads the plugins from the local repo. This feature is enabled at build time through the env flag ENABLE_PLUGINS_LOCAL.

An alternative Dockerfile.local is provided to build the local (cloned) LogSeq repository.

Caveats:

  • only plugins not requiring native electron/ipc will work
  • plugin updates are not covered by this implementation. Custom docker scripts or using LogSeq app to keep them updated can be easily developed.

Fixes: #4350, #6576

Relates with the following entries:

Screenshots:
logseq-selfhosted-local-plugins-1
logseq-selfhosted-local-plugins-2

@CLAassistant
Copy link
CLAassistant commented Jul 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shizzgar
Copy link

Yo, bugfest, nice work! But unfortunately i can't reproduce it locally.... Could you help a bit? I have cloned your fork, switched on branch with your work, builded docker image using your dockerfile following your instructions, strated Logseq but still cant view page with plugins...

@bugfest
Copy link
Author
bugfest commented Jul 28, 2024

Yo, bugfest, nice work! But unfortunately i can't reproduce it locally.... Could you help a bit? I have cloned your fork, switched on branch with your work, builded docker image using your dockerfile following your instructions, strated Logseq but still cant view page with plugins...

@shizzgar, thanks for the feedback! Happy to see this feature is well received by the community.

I've tested my PR in an clean environment and didn't have issues. I noticed the instructions to create the dot-logseq special directory weren't very clear, plugins needs to be copied to dot-logseq/plugins/. I've added more details and fixed a typo in the provided example just in case, please check the updated doc at (https://github.com/bugfest/logseq/blob/feat/plugins-local-browser/docs/docker-web-app-guide.md#with-plugins-enabled).

If you still have issues, can you share your graph directory structure?

@shizzgar
Copy link

@bugfest, thank you, man!
Works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No plugin option when running the app via Docker
3 participants
@bugfest @CLAassistant @shizzgar