8000 Version 2 by nomiddlename · Pull Request #459 · log4js-node/log4js-node · GitHub
[go: up one dir, main page]

Skip to content

Version 2 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 26, 2017
Merged

Version 2 #459

merged 15 commits into from
Mar 26, 2017

Conversation

nomiddlename
Copy link
Collaborator

This PR is mainly for my benefit, so I can look back and see what's changed between 1.x and 2.0. It is also of interest to any appender maintainers, since I've changed the way they work.

@nomiddlename nomiddlename added this to the 2.x milestone Mar 23, 2017
@codecov-io
Copy link
codecov-io commented Mar 23, 2017

Codecov Report

Merging #459 into master will increase coverage by 2.09%.
The diff coverage is 95.03%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   93.14%   95.24%   +2.09%     
==========================================
  Files          24       27       +3     
  Lines        1109      988     -121     
==========================================
- Hits         1033      941      -92     
+ Misses         76       47      -29
Impacted Files Coverage Δ
lib/appenders/dateFile.js 100% <100%> (+2.85%) ⬆️
lib/appenders/logLevelFilter.js 100% <100%> (ø) ⬆️
lib/appenders/hipchat.js 88% <100%> (-0.89%) ⬇️
lib/connect-logger.js 100% <100%> (ø) ⬆️
lib/appenders/categoryFilter.js 100% <100%> (ø) ⬆️
lib/appenders/fileSync.js 95.83% <100%> (+6.35%) ⬆️
lib/appenders/clustered.js 81.81% <100%> (ø) ⬆️
lib/appenders/file.js 100% <100%> (+2.12%) ⬆️
lib/appenders/slack.js 91.66% <100%> (-1.67%) ⬇️
lib/appenders/mailgun.js 100% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a9cfb...fd9f138. Read the comment docs.

@nomiddlename nomiddlename merged commit 406084a into master Mar 26, 2017
@nomiddlename nomiddlename deleted the version-2 branch March 26, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0