feat(console.js): use native console.error for ERROR level logs and higher #349
Conversation
|
Thanks for this. Does pm2 require your error logs to go to stderr? It sounds like you want to override the native console.* methods to get log4js style formatting, but you want error (and above) level messages to go to standard error instead of standard out - is this correct? There may be a better way to do that - I'm not sure that everyone who uses log4js will want the same thing. Perhaps we need a way to specify stdout and stderr as appenders separately, instead of just one "console" appender. What are your thoughts? |
|
Yes. I just want the error logs to go to standard error, your scheme is more suitable. Looking forward to your next release. |
|
I agree, we're currently using |
|
|
||
| function consoleAppender (layout, timezoneOffset) { | ||
| layout = layout || layouts.colouredLayout; | ||
| return function(loggingEvent) { | ||
| consoleLog(layout(loggingEvent, timezoneOffset)); | ||
| if (loggingEvent.level.level >= levels.ERROR.level) { |
There was a problem hiding this comment.
According to the node documentation, warnings are also logged to stderr since it's just an alias for console.error.
https://nodejs.org/api/console.html#console_console_warn_data
|
Does pull request #364 solve your problem? |
|
It does, but it feels weird that in order to print to Feels like we should at least provide an alias Any thoughts around this? |
|
Closing this because there are now stdout and stderr appenders. |
Only using
console.logand color to distinguish levels isn't appropriate, especially when using with 'pm2'. The error logs will be writted in normal 'out' logs.