8000 Add missing connectLogger @types/express by xseman · Pull Request #1393 · log4js-node/log4js-node · GitHub
[go: up one dir, main page]
Skip to content

Add missing connectLogger @types/express #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add missing connectLogger @types/express #1393

wants to merge 6 commits into from

Conversation

xseman
Copy link
@xseman xseman commented Sep 2, 2023 •
edited
Loading

Thanks for the great library!

I've included the optional peerDependency @types/express to replace the current any return type, to improve type accuracy.

@xseman
Copy link
Author
xseman commented May 17, 2024 •
edited
Loading

@lamweili @nomiddlename Could you please provide some feedback? Thank you!

lamweili
lamweili requested changes Jul 18, 2024
View reviewed changes
@xseman @lamweili
Update types/log4js.d.ts
a2e9423 
👍

Co-authored-by: Lam Wei Li <lam_wei_li@hotmail.com>
@lamweili lamweili added this to the 6.9.2 milestone Jul 18, 2024
@xseman
Copy link
Author
xseman commented Jul 25, 2024 •
edited
Loading

The npm install command does not include peerDependencies if they are marked as optional in peerDependenciesMeta.
To resolve issues with the tsc -p check, i can add a step to your workflow to install these optional types.

@lamweili
Copy link
Contributor

Yes please. Thanks!

@xseman
Copy link
Author
xseman commented Oct 5, 2024

@lamweili, let me know if there's anything else I can do to close this merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamweili lamweili lamweili requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@xseman @lamweili
0