10000 [feature] Add patternColoured Layout. by dignifiedquire · Pull Request #101 · log4js-node/log4js-node · GitHub
[go: up one dir, main page]
Skip to content

[feature] Add patternColoured Layout. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2012
Merged

[feature] Add patternColoured Layout. #101

merged 1 commit into from
Dec 2, 2012

Conversation

dignifiedquire
Copy link
Contributor

Based on #90 this implements the possibillity to add the color codes
according to the log level via %[ and %].

@dignifiedquire
Copy link
Contributor Author

I just realized that it's not working. Will open a new one when finished.

@nomiddlename
Copy link
Collaborator

Thanks - good job I was too slow to merge it :)

@dignifiedquire
Copy link
Contributor Author

I've fixed the problems. Should work now :)

@dignifiedquire
Copy link
Contributor Author

@nomiddlename anything new?

@nomiddlename
Copy link
Collaborator

Thanks for this - sorry for the delay, I've been at a conference for the last week. The only thing I'm concerned about in this is the duplication of patternLayout and its tests. Is there any reason why it needs to be a separate layout to patternLayout?

@dignifiedquire
Copy link
Contributor Author

No problem. No not all, I just thought as there was concern about something like this that it might be better to keep those two separate. I can put them together if you want.

@nomiddlename
Copy link
Collaborator

I think it'll be easier to maintain.

@dignifiedquire
[feature] Add color option to pattern layout.
4a7a90e 
Based on log4js-node#90 this implements the possibillity to add the color codes
according to the log level via %[ and %].
@dignifiedquire
Copy link
Contributor Author

Done.

nomiddlename pushed a commit that referenced this pull request Dec 2, 2012
Merge pull request #101 from Dignifiedquire/feature-color-pattern
8b42e46 
[feature] Add patternColoured Layout.
@nomiddlename nomiddlename merged commit 8b42e46 into log4js-node:master Dec 2, 2012
@nomiddlename
Copy link
Collaborator

Awesome. Merged, and published to npm - version 0.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @nomiddlename
0