Any chance of having a single version compatible with 0.8 and 0.10 ? #129
Comments
|
Yep - I thought about this when rewriting the file appender to handle the new streams API. I couldn't work out how to support both versions easily, so gave up. I'll have another look. |
|
I've tried to backport the old streams into the current appenders. Would you be able to take a look at the "node-0.8-backport" branch and tell me if it works for your needs, please? If it does, I'll push it to npm as a new version. |
|
I'm not sure about all the details, but wouldn't it be possible to just require readable-stream if the version is <= then 0.10. See here for an example. |
|
Ooh - cool. I'll take a look at that. |
|
Gareth, thanks a lot for looking into it, really appreciate it ! On Wed, Apr 10, 2013 at 5:29 PM, Gareth Jones notifications@github.comwrote:
|
|
Ok, log4js@0.6.3 pushed to npm. Thanks for the readable-stream suggestion, much cleaner than the half-arsed solution I came up with. |
|
@nomiddlename Thanks a lot for the quick fix! |
|
Huge thanks @nomiddlename !!! |
* upstream/master: Removed the warning about node 0.10 0.6.3 added node 0.8 to travis config and package.json backporting new streams to node 0.8 for issue log4js-node#129 0.6.2 fixed the multiprocess tests fix version of node supported Fix node engine in package.json Updated for Node 0.10.x * master:
Since 0.6.3, log4js works on both 0.8 and 0.10 so we don't have to do this hack anymore... log4js-node/log4js-node#129
Karma supports both Node 0.8 and 0.10. It depends on log4js ;-)
Because of https://github.com/isaacs/npm/issues/3305 it's very tricky to solve this problem. There's currently a hack for it (https://github.com/karma-runner/karma/blob/master/install-log4js.js). This hack however does not work when installing with sudo.
So having a single version that is compatible with both 0.8 and 0.10 would be very helpful.
The text was updated successfully, but these errors were encountered: