8000 Optimization of getFormattedTime in ~two times by VishtakAlexey · Pull Request #321 · log4cplus/log4cplus · GitHub
[go: up one dir, main page]
Skip to content

Optimization of getFormattedTime in ~two times #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

Optimization of getFormattedTime in ~two times #321

merged 1 commit into from
Jun 28, 2018

Conversation

VishtakAlexey
Copy link
Contributor

No description provided.

@wilx wilx self-assigned this Jun 28, 2018
@wilx
Copy link
Contributor
wilx commented Jun 28, 2018

LGTM. Are you claiming two times speed increase?

@wilx wilx merged commit 58169a3 into log4cplus:1.2.x Jun 28, 2018
@VishtakAlexey
Copy link
Contributor Author

Without this fix first call of strftime always failed.
It is important because function strftime is very slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilx wilx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VishtakAlexey @wilx
0