fix(isPlainObject): return true for objects with nested null prototype #6081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objects created via Object.create(Object.create(null)) should be considered plain objects since their prototype chain consists only of null-prototype objects and eventually ends in null, without any custom constructors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
60ac492 to
f5a950d
Compare
Author
|
Closing since this could result in dangerous false positives. |
Member
|
That doesn't make it a plain object - a plain object is one with no prototype methods whatsoever, meaning, it must inherit directly from null. Every single object's prototype chain terminates in |
Author
|
Yup - this was a misunderstanding I had. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects created via Object.create(Object.create(null)) should be considered plain objects since their prototype chain consists only of null-prototype objects and eventually ends in null, without any custom constructors.
This fix was made in Zod here https://github.com/colinhacks/zod/pull/4574/changes