test: add test for size with string input #5996
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cassieminkus1
approved these changes
Aug 4, 2025
ljharb
approved these changes
Dec 18, 2025
Member
|
pushed a commit to capture the unicode behavior of for string _.size relies on |
jonchurch
approved these changes
Dec 18, 2025
ljharb
requested changes
Dec 18, 2025
Member
There was a problem hiding this comment.
i'm pretty sure this is incorrect - _.size counts enumerable own string-keyed properties, not code unit pairs or graphemes.
Member
|
sorry for the back and forth, but all the docs i can find suggest it's wrong. if it's right then this PR should fix all the docs also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to verify that
_.sizecorrectly returns the length of string values.This ensures that string inputs like
'hi'return the expected length (2), aligning with Lodash documentation and behavior for string primitives.