8000 (4.17) Short circuit sortedIndexBy methods for empty arrays by megawac · Pull Request #4497 · lodash/lodash · GitHub
[go: up one dir, main page]
Skip to content

(4.17) Short circuit sortedIndexBy methods for empty arrays #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

(4.17) Short circuit sortedIndexBy methods for empty arrays #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lodash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4129,11 +4129,14 @@
* into `array`.
*/
function baseSortedIndexBy(array, value, iteratee, retHighest) {
value = iteratee(value);

var low = 0,
high = array == null ? 0 : array.length,
valIsNaN = value !== value,
high = array == null ? 0 : array.length;
if (high === 0) {
return 0;
}

value = iteratee(value);
var valIsNaN = value !== value,
valIsNull = value === null,
valIsSymbol = isSymbol(value),
valIsUndefined = value === undefined;
Expand Down
10 changes: 10 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20998,6 +20998,16 @@
assert.strictEqual(actual, 1);
});

QUnit.test('`_.' + methodName + '` should avoid calling iteratee when length is 0', function(assert) {
var objects = [],
iteratee = function() {
throw new Error;
},
actual = func(objects, { 'x': 50 }, iteratee);

assert.strictEqual(actual, 0);
});

QUnit.test('`_.' + methodName + '` should support arrays larger than `MAX_ARRAY_LENGTH / 2`', function(assert) {
assert.expect(12);

Expand Down
0